Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated the bg-emphasis style in dark mode #12933

Merged
merged 3 commits into from
Dec 29, 2023

Conversation

jaswalsaurabh
Copy link
Contributor

@jaswalsaurabh jaswalsaurabh commented Dec 22, 2023

What does this PR do?

I have changed the color of --cal-bg-emphasis of dark mode in global.css from #525252 to #404040.

Fixes #12888

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

You've to turn on the dark mode of your system or you can turn on the dark mode in cal also by navigating to the setting > appearance. Then you have to check the color of the active item of sidebar menu.

Copy link

vercel bot commented Dec 22, 2023

@jaswalsaurabh is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added Medium priority Created by Linear-GitHub Sync ui area: UI, frontend, button, form, input ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work 🧹 Improvements Improvements to existing features. Mostly UX/UI labels Dec 22, 2023
Copy link
Contributor

github-actions bot commented Dec 22, 2023

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@jaswalsaurabh jaswalsaurabh changed the title updated the bg-emphasis style in dark mode - fix: updated the bg-emphasis style in dark mode Dec 22, 2023
Copy link
Contributor

github-actions bot commented Dec 22, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@sean-brydon sean-brydon enabled auto-merge (squash) December 28, 2023 06:06
@PeerRich PeerRich changed the title - fix: updated the bg-emphasis style in dark mode fix: updated the bg-emphasis style in dark mode Dec 29, 2023
@PeerRich PeerRich enabled auto-merge (squash) December 29, 2023 17:33
@PeerRich PeerRich merged commit bdc36ac into calcom:main Dec 29, 2023
16 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧹 Improvements Improvements to existing features. Mostly UX/UI Medium priority Created by Linear-GitHub Sync ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work ui area: UI, frontend, button, form, input
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-2834] Colour referenced by bg-emphasis in dark mode (presumably stone-700) needs updating
3 participants